Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics logger to Config #231

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Add metrics logger to Config #231

merged 4 commits into from
Jun 13, 2023

Conversation

ignaciobolonio
Copy link
Contributor

@ignaciobolonio ignaciobolonio commented Jul 5, 2022

[1.14.0]

Additions

  • Config includes a metrics logger and it is called to register when a filter is used

w0rmr1d3r
w0rmr1d3r previously approved these changes Jul 11, 2022
Copy link
Member

@w0rmr1d3r w0rmr1d3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct 😄

CHANGELOG.md Outdated
Comment on lines 4 to 6
## [1.13.0]
### Additions
- `Config` includes a metrics logger and it is called to register when a filter is used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [1.13.0]
### Additions
- `Config` includes a metrics logger and it is called to register when a filter is used
## [1.13.0]
### Additions
- `Config` includes a metrics logger and it is called to register when a filter is used
- Default logging level from INFO to WARNING #230

@ignaciobolonio ignaciobolonio changed the title Add metrics logger to Config WIP Add metrics logger to Config Jul 20, 2022
blaisejoshua1
blaisejoshua1 previously approved these changes May 28, 2023
jsoucheiron
jsoucheiron previously approved these changes May 29, 2023
@ignaciobolonio ignaciobolonio changed the title WIP Add metrics logger to Config Add metrics logger to Config May 29, 2023
@jsoucheiron jsoucheiron merged commit 16993de into master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants